New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing pre-image checks for shreds in keyguard #1933

Open

ripatel-fd opened this issue May 23, 2024 · 0 comments

Labels

security

Contributor

ripatel-fd commented May 23, 2024

fd_keyguard does not verify that the pre-image of Merkle shreds is valid and unambiguous with other inputs.

The shred tile could thus sign

gossip pings
repair pings
any arbitrary 32 byte message

This is currently not a very severe issue, but it defeats the purpose of the ambiguity checks.

ripatel-fd added the security label

ripatel-fd mentioned this issue

keyguard: fix support for multiple signing methods #1932

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment