-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash with CubicChunksCore #365
Comments
https://github.com/OpenCubicChunks/CubicChunks/blob/dc16fef38129b86de11cd8a0c94069dd8eab56e4/src/main/java/io/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinEntityTracker.java#L59-L60 However, the fixRTM replaces all instantiation of EntityTrackerEntry to fixRTM's hook method in the following code. fixRTM/src/main/java/com/anatawa12/fixRtm/asm/hooking/HookingTransformer.kt Lines 23 to 53 in d23bca5
This makes incompatibility. |
If OpenCubicChunks provide us the way to detect if OpenCubicChunks is installed, if OpenCubicChunks is installed, It's possible to suppress replacing instantiation of EntityTrackerEntry in EntityTracker#track method and replace instantiation in OpenCubicChunks's hook instead. |
RTM is compatible with OCC so I'll fix this |
OpenCubicChunks/CubicChunks#741 (comment)
|
Before submitting a bug, please make sure following checks.
Descrive the bug
Original: https://discord.com/channels/749186892733480970/749187907033497601/909110518697042001
Crashes the game with CubicChunksCore.
message (2).txt
To Reproduce
Launch the game with CubicChunksCore
Expected Behavior
No Crash
Actual Behavior
Crashes
OS
Windows 8.1 (amd64) version 6.3
Minecraft Forge Version
14.23.5.2855
fixRTM Version
2.0.20
Other Mods
CubicChunksCore
The text was updated successfully, but these errors were encountered: