Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow when breaking long rails #711

Open
4 tasks done
CacPixel opened this issue Feb 26, 2024 · 0 comments
Open
4 tasks done

Stack overflow when breaking long rails #711

CacPixel opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working in fixRTM needs-triage The issues without maintainer's check

Comments

@CacPixel
Copy link
Contributor

CacPixel commented Feb 26, 2024

Before submitting a bug, please make sure following checks.

  • You have finished loading all model packs before login to world/server.
  • You're using the latest stable, snapshot, or daily-snapshot version of fixRTM.
  • You're using correct version of RTM and NGTLib for your fixRTM.
  • You couldn't find same bag in the issues.

Descrive the bug

Stack overflow when breaking long rails.
I noticed it will judge the breaking field in jp.ngt.rtm.rail.TileEntityLargeRailCore to avoid recursion too many layers, but it may not work in the latest commit of fixRTM.
The full crash report is here (ubuntu pastebin)

To Reproduce

Make a long rail in a world(hundreds of meters, such as 200m, 300m...) and break the rail (instead of breaking the rail core, breaking the rail base will cause stack overflow).
Long rail may requires more viewing distance and longer marker search distance, so adjust the horizontal line to make the rail long is possible.

Expected Behavior

The rail should break entirely in a short time without stopping the server thread.

Actual Behavior

The server thread stops processing ticks (such as player can not send messages), and StackOverflowError was thrown.
You can see many rail bases and the core still exists on the server when re-entering the game (bases doesn't exist was rendered as bedrock here):
Screenshot_2024-02-26_21-17-36

OS

Windows 10 Pro 22h2

Minecraft Forge Version

2859

fixRTM Version

commit 9eeff27: 9eeff27

Other Mods

Optifine, smoothfont, vanillafix, malisisdoors, squeedometer and more(see crash report for more details)

@CacPixel CacPixel added bug Something isn't working in fixRTM needs-triage The issues without maintainer's check labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in fixRTM needs-triage The issues without maintainer's check
Projects
None yet
Development

No branches or pull requests

2 participants