Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Replace - does not contain original value #57

Closed
MihaiMihalache opened this issue Dec 14, 2017 · 3 comments
Closed

Diff Replace - does not contain original value #57

MihaiMihalache opened this issue Dec 14, 2017 · 3 comments

Comments

@MihaiMihalache
Copy link

MihaiMihalache commented Dec 14, 2017 •
edited

When doing a diff between two jsons, for the REPLACE operation the fieldChanges should contain also the original value. I can work on this feature as I think it brings value to this library.
@vishwakarma
Copy link
Member

Hi @MihaiMihalache , please refer to my comment on your PR.
Thanks

@MihaiMihalache
Copy link
Author

Hi vishwakarma,
I updated the PR.
Thx!

@vishwakarma
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishwakarma @MihaiMihalache