copy/replace in one patch doc

[amarchewka]

If I start with the following JSON doc:
{"profiles":{"abc":[],"def":[{"hello":"world"}]}}

and apply the following patch:
[{"op":"copy","from":"/profiles/def/0", "path":"/profiles/def/0"},{"op":"replace","path":"/profiles/def/0/hello","value":"world2"}]

I get the following output:
{"profiles":{"abc":[],"def":[{"hello":"world2"},{"hello":"world2"}]}}

That is, the "replace" operation was applied to both array elements.
(Or possibly, the "replace" was applied before the "copy".)

Applying the "copy" and then the "replace" in 2 separate patch docs works as expected.

The following on-line tool [https://json-schema-validator.herokuapp.com/jsonpatch.jsp]
agrees the original output should have been
{"profiles":{"abc":[],"def":[{"hello":"world2"},{"hello":"world"}]}}
with the "replace" applied only to array element 0.

Thanks for a great library, btw!

[luliu]

I noticed in InPlaceApplyProcessor's copy function, the same valueNode object is assigned to the toPath:

zjsonpatch/src/main/java/com/flipkart/zjsonpatch/InPlaceApplyProcessor.java

Lines 53 to 59 in af15e01

	@Override
	public void copy(List<String> fromPath, List<String> toPath) {
	JsonNode parentNode = getParentNode(fromPath, Operation.COPY);
	String field = fromPath.get(fromPath.size() - 1).replaceAll("\"", "");
	JsonNode valueNode = parentNode.isArray() ? parentNode.get(Integer.parseInt(field)) : parentNode.get(field);
	add(toPath, valueNode);
	}

Is this a bug? As any mutation done to the source JsonNode in the same batch of patch operations will affect the target since they're the same object.

Here's an example:

Original document:

{"top": {"object1": {"key1":"val1","key2":"val2"}, "object2":"-----"}

Patch:

[
{"op":"copy", "from":"/top/object1", "path":"/top/object2"},
{"op":"replace","path":"/top/object1/key1","value":"++++"}
]

Result:

{"top": {"object1": {"key1":"++++","key2":"val2"}, "object2": {"key1":"++++","key2":"val2"}}}

Note that both object1 and object2's key1 changed to ++++.

[vishwakarma]

@luliu @amarchewka
Agreed, this certainly looks like a bug ( Using copy by reference instead of copy by value ), i will go deeper into the code and will fix the issue by this week.
Thank you for raising the issue.

[amarchewka]

That's great. Thanks!

[vishwakarma]

The bug is fixed, Closing the issue.

Thanks again for raising the issue.