Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PDF pages are not aligned with rnote pages #429

Closed
romanovzky opened this issue Jan 2, 2023 · 4 comments
Closed

Import PDF pages are not aligned with rnote pages #429

romanovzky opened this issue Jan 2, 2023 · 4 comments

Comments

@romanovzky
Copy link

Describe the bug
When I open a PDF through rnote, the pages are not aligned with rnote pages.

To Reproduce
Steps to reproduce the behavior:

  1. Right click on pdf
  2. Choose "Open Width"
  3. Choose "rnote"
  4. See error

(same happens when importing the pdf from a new rnote window)

Expected behavior
The pages to be aligned.

** Console Output **
There was no output.

Screenshots
Screenshot from 2023-01-02 11-07-57
Screenshot from 2023-01-02 11-07-18
Screenshot from 2023-01-02 11-07-27
Screenshot from 2023-01-02 11-07-33

Desktop (please complete the following information):

  • OS: EndeavourOS (rolling distro and kept up-to-date)
  • Version: Rnote: 0.5.12
  • Installation source: flatpak
  • Desktop Environment: Gnome 43.2
@flxzt
Copy link
Owner

flxzt commented Jan 3, 2023

It is not really a bug, the offset there is intentional. I'd say simply reducing the import page width percentage should be a solution, and / or aligning it manually after import.

A dedicated PDF annotation mode is also planned, the issue for that is #153 .

@LuckyTurtleDev
Copy link

I hit the same issue.

I'd say simply reducing the import page width percentage should be a solution, and / or aligning it manually after import.

I do not think this would be a good solution. It looks like the pdf side does match the side of rnote exactly it has only a offset to the bottom right.
The PDF annotation will be an alternative for simple drawing on pdf. But users, witch does still want to add a pdf to an existing note, will still hit this issue.
Maybe an option to map the pdf pages to the rnote pages would be a good solution.
The current solution (manual trying to hit exactly the site borders) is pretty annoying.

@flxzt
Copy link
Owner

flxzt commented Jan 3, 2023

Maybe an option to map the pdf pages to the rnote pages would be a good solution.

That is basically what I want to do as an annotation mode. There are some details I didn't work out yet though.

This way users can get both: Either import the pdf pages as individual images that can be moved and transformed freely like right now, and a dedicated mode where the layout is managed automatically. This would also enable retaining the pdf in a richer way so that new features that modify the pdf directly can be implemented in the future

@flxzt
Copy link
Owner

flxzt commented Jan 9, 2023

I'll close this, the PDF annotation mode feature progress is tracked in the other issue

@flxzt flxzt closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants