Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a continuous integration worflow #48

Open
tgdif opened this issue Nov 25, 2019 · 1 comment
Open

Add a continuous integration worflow #48

tgdif opened this issue Nov 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tgdif
Copy link

tgdif commented Nov 25, 2019

Feature Request

The proposal is to setup a GitHub workflow to run checks on every commit. For open source repositories this is free.

Motivation

This would be a quick way to check that a commit passes linting and unit tests (possibly other checks too) and could speed up reviews and identify issues.

Design Proposal

Implementation Plan

Add the necessary file to the .github/workflows directory. This has been done on a fork here https://github.com/tgdif/pyoneer/tree/continuous_integration. Note that the commit is failing one check but that is due to a separate issue with one of the existing unit tests.

Alternatives Considered

There are a variety of alternatives (Travis, CircleCI, Azure Pipelines, etc.) though this looks to be the simplest way and does not require adding a separate app.

@tgdif
Copy link
Author

tgdif commented Nov 25, 2019

Should I also upgrade some of the dependent packages in Pipfile and setup.py? These affect the environments used when running the workflow. Since tensorflow and tensorflow-probability now support TF version 2.0.0 by default on PyPI their versions can be bumped up.

@tgdif tgdif added the enhancement New feature or request label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant