Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update needed to modelVis rule for models reconstructed using CarveMe version>=1.5.0 #52

Open
shreyanshumale opened this issue Jun 5, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@shreyanshumale
Copy link

Hello, again Francisco!

I think I figured out the problem with the modelVis rule. Just small corrections are needed for users working with a carveme >1.5.0.

Changes (In the Snakefile):
In lines 1511 to 1518:

while read model;do 
            id=$(echo $(basename $model)|sed 's/.xml//g'); 
            mets=$(less $model| grep "species id="|cut -d ' ' -f 8|sed 's/..$//g'|sort|uniq|wc -l);
            rxns=$(less $model|grep -c 'reaction id=');
            genes=$(less $model|grep 'fbc:geneProduct fbc:id='|grep -vic spontaneous);
            echo "Model: $id has $mets mets, $rxns reactions, and $genes genes ... "
            echo "$id $mets $rxns $genes" >> GEMs.stats;
        done< <(find . -name "*.xml")
  1. species id ----->species metaid
  2. reaction id ------>reaction metaid
  3. fbc:geneProduct fbc:id ------>fbc:geneProduct metaid

These changes are reflected in a smooth run of this rule!

I hope this helps!

P.S.: I am still trying to figure out the multiple job submission on an OGE cluster and the memote errors. I will keep you posted if I find something!

Thanks and regards,
Shreyansh

@franciscozorrilla franciscozorrilla self-assigned this Jun 6, 2021
@franciscozorrilla franciscozorrilla added the bug Something isn't working label Jun 6, 2021
@franciscozorrilla
Copy link
Owner

Hey Shreyansh,

Thank you for bringing this up, I would not have found this bug myself since I am using v1.4.1 of CarveMe.
Will implement your suggested changes soon :)

Best wishes,
Francisco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants