Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially add additional maintainers #30

Open
CosmicHorrorDev opened this issue Oct 25, 2021 · 8 comments
Open

Potentially add additional maintainers #30

CosmicHorrorDev opened this issue Oct 25, 2021 · 8 comments

Comments

@CosmicHorrorDev
Copy link
Collaborator

It looks like this crate has fallen out of maintenance for the past couple of years leading to slack-hook2 and slack-hook3 which both mention in their README's that they are happy to merge the changes back to here in the future.

If maintaining this crate is too time/effort consuming then you could add me (and/or others) as maintainers to spread the load across multiple people, and keep this crate more up to date

@compressed
Copy link
Contributor

Thanks for the note @LovecraftianHorror! And apologies to all for my lack of activity here. I'd be happy to add additional maintainers. I had at one point attempted to merge the blocking and non-blocking work together, but didn't have enough time to finish / reduce some of the duplication.

I've added you to the repo!

@CosmicHorrorDev
Copy link
Collaborator Author

No worries! Life has a way of keeping people busy at times

I'll take some time this weekend to get things more up to date

@compressed
Copy link
Contributor

Great, thank you so much!

@CosmicHorrorDev
Copy link
Collaborator Author

I went ahead and opened a couple of pull requests to get things more up to speed (#31 and #32). I'm not sure if you're fine with me just merging all on my own or if you prefer reviewing things first. Either option is totally fine with me

@compressed
Copy link
Contributor

Great, thank you so much! At least to start, I'd like to review any changes.

@CosmicHorrorDev
Copy link
Collaborator Author

Alright so just to give some insight on the direction I'm going currently. My current goal is to

  • Get things in the library up to date with current Rust (Finished after Update to 2018 edition #33)
  • Bump the dependencies
  • Merge any PRs from the backlog that still seem applicable and don't cause breaking changes
    • A lot lump several changes all together which is why I preferred redoing the work in smaller PRs myself
  • Make a release with as few breaking changes as possible so that people can easily update to it

After that I can work on some additional cleanup and work towards potentially exposing an async API alongside the current blocking one

@compressed
Copy link
Contributor

Perfect, that sounds like a great plan!

@CosmicHorrorDev
Copy link
Collaborator Author

Apologies for the ping @compressed. I'm assuming you're busy again. If you don't have time for on-boarding additional maintainers then you could give me or rust bus crates.io privileges to keep things moving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants