Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify condition for picking terraform after trying to decode state #787

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Feb 5, 2024

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:

The overall previous stricter check was causing issues in shoots that had not been reconciled for a long time and contained no state. The additional check done by decoding the state into the previous format, did not provide much benefit.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

fix an issue where an empty infrastructure state would cause issues when picking the proper reconciler.

@kon-angelo kon-angelo requested review from a team as code owners February 5, 2024 15:18
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 5, 2024
@kon-angelo
Copy link
Contributor Author

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 26, 2024
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kon-angelo kon-angelo merged commit ee8a88b into gardener:master Feb 27, 2024
7 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/bug Bug kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/azure Microsoft Azure platform/infrastructure reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants