Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new SDK clients and update deps #833

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Switch to new SDK clients and update deps #833

merged 7 commits into from
Apr 23, 2024

Conversation

AndreasBurger
Copy link
Member

@AndreasBurger AndreasBurger commented Apr 17, 2024 •
edited

How to categorize this PR?

/area quality
/kind task
/platform azure

What this PR does / why we need it:
Incorporates the Upgrade PR proposed by dependabot and updates most clients of the old SDK to the new one.

Release note:

Update clients for dns, storage, compute, and msi to use the new Azure SDK libraries

@gardener-robot gardener-robot added the platform/azure Microsoft Azure platform/infrastructure label Apr 17, 2024
@gardener-robot
Copy link

@AndreasBurger Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 17, 2024
@AndreasBurger AndreasBurger mentioned this pull request Apr 17, 2024
Closed
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Apr 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2024
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/rebase Needs git rebase labels Apr 18, 2024
@gardener-robot
Copy link

@AndreasBurger You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2024
@AndreasBurger AndreasBurger marked this pull request as ready for review April 18, 2024 14:52
@AndreasBurger AndreasBurger requested a review from a team as a code owner April 18, 2024 14:52
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2024
@AndreasBurger
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Apr 19, 2024 •
edited

Testrun: e2e-h9j5f
Workflow: e2e-h9j5f-wf
Phase: Failed

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| bastion-test        | bastion-test              | Succeeded | 8m22s    |
| infrastructure-test | infra-flow-migration-test | Failed    | 33m14s   |
| infrastructure-test | infrastructure-test       | Omitted   | 0s       |
| infrastructure-test | infra-flow-test           | Omitted   | 0s       |
+---------------------+---------------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
dependabot bot and others added 5 commits April 23, 2024 13:53
@dependabot @AndreasBurger
Bump the all-dependencies group with 21 updates
8523ac8 
Bumps the all-dependencies group with 21 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/Azure/azure-sdk-for-go](https://github.com/Azure/azure-sdk-for-go) | `61.1.0+incompatible` | `68.0.0+incompatible` |
| [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) | `1.7.1` | `1.11.1` |
| [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) | `1.3.1` | `1.5.2` |
| [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5](https://github.com/Azure/azure-sdk-for-go) | `5.1.0` | `5.6.0` |
| [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4](https://github.com/Azure/azure-sdk-for-go) | `4.1.0` | `4.3.0` |
| [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources](https://github.com/Azure/azure-sdk-for-go) | `1.1.1` | `1.2.0` |
| [github.com/Azure/azure-storage-blob-go](https://github.com/Azure/azure-storage-blob-go) | `0.8.0` | `0.15.0` |
| [github.com/Azure/go-autorest/autorest/to](https://github.com/Azure/go-autorest) | `0.3.0` | `0.4.0` |
| [github.com/AzureAD/microsoft-authentication-library-for-go](https://github.com/AzureAD/microsoft-authentication-library-for-go) | `1.1.1` | `1.2.2` |
| [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) | `2.17.0` | `2.17.1` |
| [go.uber.org/atomic](https://github.com/uber-go/atomic) | `1.10.0` | `1.11.0` |
| [golang.org/x/crypto](https://github.com/golang/crypto) | `0.21.0` | `0.22.0` |
| [golang.org/x/tools](https://github.com/golang/tools) | `0.17.0` | `0.20.0` |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.29.3` | `0.29.4` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.29.3` | `0.29.4` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.29.3` | `0.29.4` |
| [k8s.io/autoscaler/vertical-pod-autoscaler](https://github.com/kubernetes/autoscaler) | `1.0.0` | `1.1.0` |
| [k8s.io/code-generator](https://github.com/kubernetes/code-generator) | `0.29.3` | `0.29.4` |
| [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.29.3` | `0.29.4` |
| [k8s.io/kubelet](https://github.com/kubernetes/kubelet) | `0.29.3` | `0.29.4` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.17.2` | `0.17.3` |


Updates `github.com/Azure/azure-sdk-for-go` from 61.1.0+incompatible to 68.0.0+incompatible
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@v61.1.0...v68.0.0)

Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.7.1 to 1.11.1
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.7.1...sdk/azcore/v1.11.1)

Updates `github.com/Azure/azure-sdk-for-go/sdk/azidentity` from 1.3.1 to 1.5.2
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.3.1...sdk/internal/v1.5.2)

Updates `github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5` from 5.1.0 to 5.6.0
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/resourcemanager/netapp/armnetapp/v5.1.0...sdk/resourcemanager/compute/armcompute/v5.6.0)

Updates `github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4` from 4.1.0 to 4.3.0
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/resourcemanager/netapp/armnetapp/v4.1.0...sdk/resourcemanager/network/armnetwork/v4.3.0)

Updates `github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources` from 1.1.1 to 1.2.0
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.1.1...v1.2)

Updates `github.com/Azure/azure-storage-blob-go` from 0.8.0 to 0.15.0
- [Release notes](https://github.com/Azure/azure-storage-blob-go/releases)
- [Changelog](https://github.com/Azure/azure-storage-blob-go/blob/master/ChangeLog.md)
- [Commits](Azure/azure-storage-blob-go@v0.8.0...v0.15.0)

Updates `github.com/Azure/go-autorest/autorest/to` from 0.3.0 to 0.4.0
- [Release notes](https://github.com/Azure/go-autorest/releases)
- [Changelog](https://github.com/Azure/go-autorest/blob/main/CHANGELOG.md)
- [Commits](Azure/go-autorest@tracing/v0.3.0...tracing/v0.4.0)

Updates `github.com/AzureAD/microsoft-authentication-library-for-go` from 1.1.1 to 1.2.2
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-go/releases)
- [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/main/changelog.md)
- [Commits](AzureAD/microsoft-authentication-library-for-go@v1.1.1...v1.2.2)

Updates `github.com/onsi/ginkgo/v2` from 2.17.0 to 2.17.1
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.17.0...v2.17.1)

Updates `go.uber.org/atomic` from 1.10.0 to 1.11.0
- [Release notes](https://github.com/uber-go/atomic/releases)
- [Changelog](https://github.com/uber-go/atomic/blob/master/CHANGELOG.md)
- [Commits](uber-go/atomic@v1.10.0...v1.11.0)

Updates `golang.org/x/crypto` from 0.21.0 to 0.22.0
- [Commits](golang/crypto@v0.21.0...v0.22.0)

Updates `golang.org/x/tools` from 0.17.0 to 0.20.0
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.17.0...v0.20.0)

Updates `k8s.io/api` from 0.29.3 to 0.29.4
- [Commits](kubernetes/api@v0.29.3...v0.29.4)

Updates `k8s.io/apiextensions-apiserver` from 0.29.3 to 0.29.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.29.3...v0.29.4)

Updates `k8s.io/apimachinery` from 0.29.3 to 0.29.4
- [Commits](kubernetes/apimachinery@v0.29.3...v0.29.4)

Updates `k8s.io/autoscaler/vertical-pod-autoscaler` from 1.0.0 to 1.1.0
- [Release notes](https://github.com/kubernetes/autoscaler/releases)
- [Commits](kubernetes/autoscaler@cluster-autoscaler-1.0.0...cluster-autoscaler-1.1.0)

Updates `k8s.io/code-generator` from 0.29.3 to 0.29.4
- [Commits](kubernetes/code-generator@v0.29.3...v0.29.4)

Updates `k8s.io/component-base` from 0.29.3 to 0.29.4
- [Commits](kubernetes/component-base@v0.29.3...v0.29.4)

Updates `k8s.io/kubelet` from 0.29.3 to 0.29.4
- [Commits](kubernetes/kubelet@v0.29.3...v0.29.4)

Updates `sigs.k8s.io/controller-runtime` from 0.17.2 to 0.17.3
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.17.2...v0.17.3)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/azure-storage-blob-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/Azure/go-autorest/autorest/to
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/AzureAD/microsoft-authentication-library-for-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: go.uber.org/atomic
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: k8s.io/autoscaler/vertical-pod-autoscaler
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: k8s.io/code-generator
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: k8s.io/kubelet
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@AndreasBurger
switch to new dns client version
7280186
@AndreasBurger
switch to new storage client version
b9f5756
@AndreasBurger
switch to new armcompute client
6b91811
@AndreasBurger
switch to new SDK client for azure msi
d3477f1
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 23, 2024
@AndreasBurger AndreasBurger added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@AndreasBurger
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Apr 23, 2024 •
edited

Testrun: e2e-d64k4
Workflow: e2e-d64k4-wf
Phase: Succeeded

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| bastion-test        | bastion-test              | Succeeded | 8m6s     |
| infrastructure-test | infra-flow-migration-test | Succeeded | 32m8s    |
| infrastructure-test | infrastructure-test       | Succeeded | 30m47s   |
| infrastructure-test | infra-flow-test           | Succeeded | 24m44s   |
+---------------------+---------------------------+-----------+----------+

kon-angelo
kon-angelo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 23, 2024
@AndreasBurger AndreasBurger merged commit 1aca6d6 into gardener:master Apr 23, 2024
14 checks passed
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/api-change API change with impact on API users kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndreasBurger @gardener-robot @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3