Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.42] Automated cherry pick of #841: add rg deletion at end of tf.destroy #842

Merged
merged 5 commits into from
Apr 25, 2024
Merged

[release-v1.42] Automated cherry pick of #841: add rg deletion at end of tf.destroy #842

merged 5 commits into from
Apr 25, 2024

Conversation

kon-angelo
Copy link
Contributor

/area control-plane
/kind bug

Cherry pick of #841 on release-v1.42.

#841: add rg deletion at end of tf.destroy

Release Notes:

Fix a bug where the terraform-provider-azure would not properly delete shoot resource groups. The infrastructure-controller will issue an additional delete operation for the shoot's resource group.

@kon-angelo kon-angelo requested review from a team as code owners April 24, 2024 15:38
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug labels Apr 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Apr 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2024
timuthy
timuthy approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@kon-angelo kon-angelo merged commit ae2b246 into gardener:release-v1.42 Apr 25, 2024
9 checks passed
@kon-angelo kon-angelo deleted the automated-cherry-pick-of-#841-origin-release-v1.42 branch April 25, 2024 06:32
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kon-angelo @timuthy @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot