Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controlplaneexposure-webhook: Don't do no-op mutations for Services and Deployments #862

Merged
merged 1 commit into from
May 21, 2024
Merged

controlplaneexposure-webhook: Don't do no-op mutations for Services and Deployments #862

merged 1 commit into from
May 21, 2024

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area scalability
/kind enhancement
/platform azure

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-aws#952

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The `controlplaneexposure.azure.extensions.gardener.cloud` webhook does no longer mutate Services/Deployments. Previously the webhook was called for Services/Deployments mutations and was not mutating anything.

@ialidzhikov ialidzhikov requested review from a team as code owners May 15, 2024 13:11
@gardener-robot gardener-robot added area/scalability Scalability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 15, 2024
AndreasBurger
AndreasBurger approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndreasBurger AndreasBurger merged commit 4f96c18 into gardener:master May 21, 2024
15 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot