Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed handling for data disk in tobedetached state during vm deletion #132

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fixed handling for data disk in tobedetached state during vm deletion #132

merged 1 commit into from
Feb 20, 2024

Conversation

unmarshall
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #131

Special notes for your reviewer:

Release note:

Fixed handling for data disk in ToBeDetached=true state during vm deletion

@unmarshall unmarshall requested review from a team as code owners February 20, 2024 06:13
@gardener-robot gardener-robot added the needs/review Needs review label Feb 20, 2024
@unmarshall unmarshall self-assigned this Feb 20, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Feb 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 20, 2024
rishabh-11
rishabh-11 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 20, 2024
@rishabh-11 rishabh-11 merged commit 1e95ec7 into gardener:master Feb 20, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@unmarshall unmarshall

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If disk is marked for detachment then one should delete the VM
5 participants
@unmarshall @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot