Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle MarketPlaceImages with no purchase plan defined as valid case #134

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Handle MarketPlaceImages with no purchase plan defined as valid case #134

merged 1 commit into from
Feb 21, 2024

Conversation

unmarshall
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #133

Special notes for your reviewer:

Release note:

Fixed the gap where VM marketplace images with no plans were not handled properly. Now one can start VMs having marketplace image with no plan.

@unmarshall unmarshall requested review from a team as code owners February 21, 2024 04:33
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 21, 2024
rishabh-11
rishabh-11 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
@rishabh-11 rishabh-11 self-assigned this Feb 21, 2024
elankath
elankath approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@elankath elankath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clearly need not have a Plan in order to Execute.

@rishabh-11 rishabh-11 merged commit 1d9430c into gardener:master Feb 21, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 21, 2024
@unmarshall unmarshall deleted the planfix branch February 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elankath elankath elankath approved these changes

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle MarketPlaceImages with no purchase plan defined as valid case
6 participants
@unmarshall @elankath @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot