Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date interpretation depends on the current date, not the snapshot date #18

Open
MattBlissett opened this issue Jan 20, 2021 · 0 comments

Comments

@MattBlissett
Copy link
Member

Collection/event date interpretation has an upper bound of tomorrow (to take account of timezones) during normal interpretation: https://github.com/gbif/occurrence/blob/occurrence-0.154/occurrence-processor/src/main/java/org/gbif/occurrence/processor/interpreting/TemporalInterpreter.java#L65

"Tomorrow" is still used when reinterpreting snapshots. The snapshot from 2013-12-11 has this data:

Raw                     As reinterpreted on 2021-01-15
2021    1       1       2021    1       1
2021    1       7       2021    1       7
2021    1       9       2021    1       9
2021    1       14      2021    1       14
2021    1       18      NULL    NULL    NULL
2021    1       27      NULL    NULL    NULL
2021    1       27      NULL    NULL    NULL
2021    1       29      NULL    NULL    NULL
2021    1       30      NULL    NULL    NULL

These dates are all bad (the occurrences cannot have been collected/observed 8 years in the future), but we will reinterpret them as correct in the April analytics run.

This is not a unique case, e.g. most (all?) snapshots have at least one occurrence with an event year of 2021:

"2007-12-19",2021,1
"2008-04-01",2021,1
"2008-06-27",2021,1
"2008-10-10",2021,1
"2008-12-17",2021,1
"2009-04-06",2021,1
"2009-06-17",2021,1
"2009-09-25",2021,1
"2009-12-16",2021,1
"2010-04-01",2021,1
"2010-07-26",2021,1
"2010-11-17",2021,1
"2011-02-21",2021,2
"2011-06-10",2021,1
"2011-09-05",2021,1
"2012-01-18",2021,1
"2012-03-26",2021,1
"2012-07-13",2021,1
"2012-10-31",2021,144
"2012-12-11",2021,148
"2013-02-20",2021,143
"2013-05-21",2021,14
"2013-07-09",2021,12
"2013-09-10",2021,12
"2013-12-20",2021,12
"2014-03-28",2021,12
"2014-09-08",2021,12
"2015-01-19",2021,12
"2015-04-09",2021,12
"2015-07-03",2021,3
"2015-10-01",2021,3
"2016-01-04",2021,3
"2016-04-05",2021,2
"2016-07-04",2021,3
"2016-10-07",2021,2
"2016-12-27",2021,2
"2017-04-12",2021,3
"2017-07-24",2021,3
"2017-10-12",2021,14
"2017-12-22",2021,14
"2018-04-09",2021,23
"2018-07-11",2021,23
"2018-09-28",2021,20
"2019-01-01",2021,20
"2019-04-06",2021,23
"2019-07-01",2021,22
"2019-10-09",2021,22
"2020-01-01",2021,14
"2020-04-01",2021,15
"2020-07-01",2021,11
"2020-10-01",2021,11
"2021-01-01",2021,120

This prevents rerunning the analytics and getting the same figures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant