Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider SVGs instead of PNGs for analytics images #1340

Closed
MattBlissett opened this issue Apr 7, 2020 · 2 comments
Closed

Consider SVGs instead of PNGs for analytics images #1340

MattBlissett opened this issue Apr 7, 2020 · 2 comments
Assignees

Comments

@MattBlissett
Copy link
Member

I've fixed the small error in the analytics that was causing SVG graphs to be a different size compared to the PNG ones.

Using them directly (without going through Thumbor) would avoid us having to drop the Thumbor cache when new analytics are released, and give crisp graphs even on my 4K screen.

(In writing this, I notice the font is serif instead of sans-serif. I'll look at fixing that later.)

@MattBlissett
Copy link
Member Author

PNG: PNG

SVG: SVG

Comparison as I see it: image

@MattBlissett
Copy link
Member Author

It would really make the release process for analytics simpler if these SVGs were used instead of the PNGs.

The current PNGs thumbnails still appear fuzzy on both Firefox and Chromium on Linux and MacOS on hi-definition screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants