Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better solution to fromString. #6

Open
gburtini opened this issue May 21, 2017 · 0 comments
Open

Figure out a better solution to fromString. #6

gburtini opened this issue May 21, 2017 · 0 comments

Comments

@gburtini
Copy link
Owner

The XPathQuery and XPathNode objects both support a partially implemented fromString at the moment. It is left out of the documentation because it is not well supported. They rely partially on the Jison XPath parser and partially on a custom parsing implementation.

There's two options here: eliminate support and only have the already built fromDom (most reliable) or greatly evolve the support to work from the Jison parse tree. Note that Potent requires the fromString support to provide a nice UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant