Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Allow people to set their desired language via SMS #77

Open
2 tasks
kimadactyl opened this issue May 12, 2021 · 2 comments
Open
2 tasks

feature: Allow people to set their desired language via SMS #77

kimadactyl opened this issue May 12, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers minor Adds functionality in a backwards-compatible manner

Comments

@kimadactyl
Copy link
Member

Overview

Language is set by an admin. This presumes that we know it, and that the translations are all of even quality. It also makes testing harder.

Scope

Add an additional command that allows listing and setting languages

Acceptance Criteria

  • I can do a command to see available langauges
  • I can set my language via SMS

Questions/Assumptions

Is this going to get really silly for SMS lengths if we add a dozen languages?

@github-actions github-actions bot added enhancement New feature or request minor Adds functionality in a backwards-compatible manner labels May 12, 2021
@kimadactyl kimadactyl changed the title feat: Allow people to set their desired language via SMS feature: Allow people to set their desired language via SMS May 12, 2021
@wheresalice wheresalice added the good first issue Good for newcomers label May 12, 2021
@wheresalice
Copy link
Contributor

Do we want to send the list of languages in English? Or the member's current language? Or the language's language?

Should we accept the chosen language in multiple languages?

We need some example text and commands to work against here.

@kimadactyl
Copy link
Member Author

kimadactyl commented May 26, 2021

Yeah OK this is a complicated ticket.

Maybe for v1 we just accept the country code?

So add this to the list (will need to do #87 first) "LANG: update your language"

Sending LANG then says

To set your language, send LANG followed by your country code.

For example: 'LANG ar'

Available languages are:

- Arabic (ar)
- English (en)
- French (fr)

after lang ar you get

I set your language to Arabic! (Local greeting)

A couple things:

  • we should treat the languages like postcodes -- first part match is fine if we only have one
  • is it possible to autogenerate the list of langauges in the language this gets translated to?
  • i think flag emojis would make this more readable esp if you get out your language but then what flag would we use for arabic?

let's talk it out a bit more before we get stuck in with others too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers minor Adds functionality in a backwards-compatible manner
Projects
None yet
Development

No branches or pull requests

2 participants