Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mako cleanup] General python code removal #3240

Open
procrastinatio opened this issue Aug 10, 2019 · 1 comment
Open

[Mako cleanup] General python code removal #3240

procrastinatio opened this issue Aug 10, 2019 · 1 comment
Labels
1st prio PY3

Comments

@procrastinatio
Copy link
Contributor

procrastinatio commented Aug 10, 2019 •
edited
Loading

python code is not supposed to be in mako

  • Class definition in mako
  • PDF and data download code

Downloading or performing any network tests should not be made in the mako code (Remember it's a template engine).
When data.geo.admin.ch is down, the application will fail tests.
@procrastinatio
Copy link
Contributor Author

Also way too much python code in makos.

@procrastinatio procrastinatio changed the title [Mako cleanup] Remove data download from mako code [Mako cleanup] General python code removal Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1st prio PY3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@procrastinatio