Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load fake tlds from config file #33

Closed
istiak101 opened this issue Dec 16, 2023 · 2 comments
Closed

Load fake tlds from config file #33

istiak101 opened this issue Dec 16, 2023 · 2 comments
Assignees
@getpinga
Labels
enhancement New feature or request

Comments

@istiak101
Copy link
Contributor

I don't get it why this should verify valid tlds from ICANN.

Anyway this should be loadable from config file rather than being hardcoded.

registry/cp/bootstrap/helper.php

Line 285 in b4ccc2b

$fakeTlds = ['test', 'xx'];

@getpinga getpinga self-assigned this Dec 17, 2023
@getpinga getpinga added the enhancement New feature or request label Dec 17, 2023
@getpinga
Copy link
Contributor

Thanks, good find. Will work on it.

@getpinga getpinga mentioned this issue Dec 29, 2023
Closed
@getpinga
Copy link
Contributor

This has been now fixed. Please test and let me know if there are further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getpinga getpinga

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@istiak101 @getpinga