-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow manually specifying application id, version name and code #79
Comments
@lwasyl Do you use Sentry Android Gradle Plugin? If not, why? |
@bruno-garcia I am but it's not working as expected supposedly due to getsentry/sentry-android-gradle-plugin#37. All I know is for now our release has no proguard mappings even though the plugin was applied correctly. Other than that as a principle I'm trying to avoid Gradle plugins for things that can be easily done without it. I already spent some time understanding how Sentry matches Proguard mappings and the entire thing is needlessly convoluted for the simple use case: every release version has its unique mapping file. I opened getsentry/sentry-java#1333 and I'd have much higher confidence in having Proguard work with those simple pieces:
And I just realized that my request is wrong. I don't need to specify version code and version name, I need to specify proguard mapping ID (which sentry-cli also allows): sentry_upload_proguard(
auth_token: 'my_token',
org_slug: 'my_org',
project_slug: 'my_project',
app_id: 'com.my.app.id',
mapping_uuid: 'com.my.app.id-130', # I'd set the same ID in the app
mapping_path: 'build.proguard.txt',
) |
Hey @lwasyl, |
We are also happy to accept PRs if you are motivated @lwasyl ;) |
Hey @philipphofmann I wasn't motivated but someone was, unfortunately they PR was left ignored for a year and ultimately closed: #80 |
Thanks for pointing that out, @lwasyl. I replied in the PR #80 (comment). |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sentry CLI allows uploading proguard mappings by specifying application id, version name and version code manually, without pointing it to manifest file. This request is to provide the same configuration in Sentry Fastlane plugin, such that I can write
The text was updated successfully, but these errors were encountered: