Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually specifying application id, version name and code #79

Open
lwasyl opened this issue Mar 16, 2021 · 7 comments
Open

Allow manually specifying application id, version name and code #79

lwasyl opened this issue Mar 16, 2021 · 7 comments

Comments

@lwasyl
Copy link

lwasyl commented Mar 16, 2021

Sentry CLI allows uploading proguard mappings by specifying application id, version name and version code manually, without pointing it to manifest file. This request is to provide the same configuration in Sentry Fastlane plugin, such that I can write

sentry_upload_proguard(
  auth_token: 'my_token', 
  org_slug: 'my_org',
  project_slug: 'my_project',
  app_id: 'com.my.app.id',
  app_version_code: 21,
  app_version_name: "3.7"
  mapping_path: 'build.proguard.txt',
)
@bruno-garcia
Copy link
Member

@lwasyl Do you use Sentry Android Gradle Plugin? If not, why?

@lwasyl
Copy link
Author

lwasyl commented Mar 19, 2021

@bruno-garcia I am but it's not working as expected supposedly due to getsentry/sentry-android-gradle-plugin#37. All I know is for now our release has no proguard mappings even though the plugin was applied correctly.

Other than that as a principle I'm trying to avoid Gradle plugins for things that can be easily done without it. I already spent some time understanding how Sentry matches Proguard mappings and the entire thing is needlessly convoluted for the simple use case: every release version has its unique mapping file. I opened getsentry/sentry-java#1333 and I'd have much higher confidence in having Proguard work with those simple pieces:

  • attaching stable proguard mapping ID generated from application ID and version code, without generating any properties files as these values are easily retrieved in runtime
  • uploading proguard mapping with the same ID during the release process, where we also know application ID and version code because we're just making a release so we need to know both

And I just realized that my request is wrong. I don't need to specify version code and version name, I need to specify proguard mapping ID (which sentry-cli also allows):

sentry_upload_proguard(
  auth_token: 'my_token', 
  org_slug: 'my_org',
  project_slug: 'my_project',
  app_id: 'com.my.app.id',
  mapping_uuid: 'com.my.app.id-130', # I'd set the same ID in the app
  mapping_path: 'build.proguard.txt',
)

@philipphofmann
Copy link
Member

Hey @lwasyl,
thanks for explaining why you need this feature. If the sentry-cli supports the UUID for the proguard upload I don't see any reason why we shouldn't support it at well via fastlane. I can't give you an ETA though for this. Please upvote if anybody else wants this feature too.

@philipphofmann
Copy link
Member

We are also happy to accept PRs if you are motivated @lwasyl ;)

@lwasyl
Copy link
Author

lwasyl commented Apr 21, 2022

Hey @philipphofmann I wasn't motivated but someone was, unfortunately they PR was left ignored for a year and ultimately closed: #80

@philipphofmann
Copy link
Member

Thanks for pointing that out, @lwasyl. I replied in the PR #80 (comment).

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants