feat(grid): add deleteDataGridItem & deleteDataGridItemById into Service

ghiscoding · Apr 13, 2018 · 2e927f2 · 2e927f2
1 parent bf83c90
commit 2e927f2
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 8 deletions.
diff --git a/aurelia-slickgrid/src/aurelia-slickgrid/services/gridExtra.service.ts b/aurelia-slickgrid/src/aurelia-slickgrid/services/gridExtra.service.ts
@@ -128,15 +128,48 @@ export class GridExtraService {
   }
 
   /**
-   * Update an existing item with new properties inside the datagrid
+   * Delete an existing item from the datagrid (dataView)
+   * @param object item: item object holding all properties of that row
+   */
+  deleteDataGridItem(item: any) {
+    const row = this._dataView.getRowById(item.id);
+    const itemId = (!item || !item.hasOwnProperty('id')) ? -1 : item.id;
+
+    if (itemId === -1) {
+      throw new Error(`Could not find the item in the grid or it's associated "id"`);
+    }
+
+    // delete the item from the dataView
+    this._dataView.deleteItem(itemId);
+    this._dataView.refresh();
+  }
+
+  /**
+   * Delete an existing item from the datagrid (dataView)
+   * @param object item: item object holding all properties of that row
+   */
+  deleteDataGridItemById(id: string | number) {
+    const row = this._dataView.getRowById(id);
+
+    if (!row) {
+      throw new Error(`Could not find the item in the grid by it's associated "id"`);
+    }
+
+    // delete the item from the dataView
+    this._dataView.deleteItem(id);
+    this._dataView.refresh();
+  }
+
+  /**
+   * Update an existing item with new properties inside the datagrid (dataView)
    * @param object item: item object holding all properties of that row
    */
   updateDataGridItem(item: any) {
     const row = this._dataView.getRowById(item.id);
     const itemId = (!item || !item.hasOwnProperty('id')) ? -1 : item.id;
 
     if (itemId === -1) {
-      throw new Error(`Could not find the item in the item in the grid or it's associated "id"`);
+      throw new Error(`Could not find the item in the grid or it's associated "id"`);
     }
 
     const gridIdx = this._dataView.getIdxById(itemId);

diff --git a/aurelia-slickgrid/src/examples/slickgrid/example3.ts b/aurelia-slickgrid/src/examples/slickgrid/example3.ts
@@ -251,8 +251,7 @@ export class Example3 {
       }
       if (column.columnDef.id === 'delete') {
         if (confirm('Are you sure?')) {
-          this.dataview.deleteItem(column.dataContext.id);
-          this.dataview.refresh();
+          this.gridExtraService.deleteDataGridItemById(column.dataContext.id);
         }
       }
     });

diff --git a/client-cli/src/examples/slickgrid/example3.js b/client-cli/src/examples/slickgrid/example3.js
@@ -235,8 +235,7 @@ export class Example3 {
       }
       if (column.columnDef.id === 'delete') {
         if (confirm('Are you sure?')) {
-          this.dataview.deleteItem(column.dataContext.id);
-          this.dataview.refresh();
+          this.gridExtraService.deleteDataGridItemById(column.dataContext.id);
         }
       }
     });

diff --git a/doc/github-demo/src/examples/slickgrid/example3.ts b/doc/github-demo/src/examples/slickgrid/example3.ts
@@ -251,8 +251,7 @@ export class Example3 {
       }
       if (column.columnDef.id === 'delete') {
         if (confirm('Are you sure?')) {
-          this.dataview.deleteItem(column.dataContext.id);
-          this.dataview.refresh();
+          this.gridExtraService.deleteDataGridItemById(column.dataContext.id);
         }
       }
     });