-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triple-colon ligature in ss07 has odd cursor placement in specific scenarios #216
Comments
Scribus seems to handle this correctly. My VScode font setup is below, but I can not get these red things to appear, which language is that? What I noticed is that the new ligs are 'backwards', while usually they are 'forward', hmm, but that should not make any difference. |
@Finii Yes, it's only when there are red squigglies. It renders fine when there is no error being reported, and even in some other language when red squiggles are present. I'm using a Rust project. Should be possible to repro using a fresh project, after running Full repro:
My relevant editor settings are: {
"editor.fontFamily": "'Monaspace Neon', Consolas, 'Courier New', monospace",
"editor.fontLigatures": "'calt', 'liga', 'ss01', 'ss02', 'ss03', 'ss06', 'ss07'",
} I was also able to confirm the issue happening with only the This is on Windows 11 23H2 using Monaspace Neon v1.101 (I double-checked the installed version) and vscode 1.89.1. Interestingly, this doesn't happen with TypeScript errors: I'm not completely sure why this specifically happens with Rust. It may be where the errors are being marked by I'm also wondering if this is an issue specifically with how vscode renders the text when squigglies are involved. To be honest, I don't even know how to begin debugging this kind of problem, or I'd try to offer more direction. If you do try the repro steps, let me know if you're unable to reproduce it. |
In
vscode
, the interaction between the triple-colon ligature from ss07 (:::
) and red squigglies seems to cause issues with cursor placement. Under certain circumstances, the triple-colon ligature renders correctly, but the cursor treats it as two 1.5-wide colon characters and a single 0-width colon.I've observed this issue in v1.100 and v1.101, but not in v1.000.
In this screenshot, the cursor is logically placed between the 1st and 2nd colon from the left, but visually appears in the middle of the 2nd colon:
Moving the cursor right by 1 character places it at the end of the
:::
, and moving it right again doesn't visually move the cursor.After moving it right once:
And again (no visual change):
It's also worth noting that this only seems to happen when red squigglies are involved on the right side of the triple-colon ligature:
This is with
ss07
disabled:This is from v1.000, which doesn't appear to have the ligature:
Also, this seems to only happen with Monaspace's triple-colon ligature. Here's an example of how it looks with Fira Code and its ligatures enabled:
(I had originally posted about this in the Nerd Fonts repo related to a different issue I had come across, but this appears to be Monaspace.)
The text was updated successfully, but these errors were encountered: