Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow column name to be used in details function for column #155

Closed
ksnap28 opened this issue May 5, 2021 · 2 comments
Closed

Allow column name to be used in details function for column #155

ksnap28 opened this issue May 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ksnap28
Copy link

ksnap28 commented May 5, 2021

Thank you for this package. I just started using it recently and it has been fantastic!

I have a table where the number of columns displayed and the names of those columns can vary. I would like to display details for some of the cells, however for my use case I need the name of the column to determine the information to show. Unfortunately, right now the details function only allows the row index to be used. Would it be possible to also allow the column name to be used?

I got this working in my local copy by including key as a parameter to the details callFunc function. I can do a pull request if this is something you would like to incorporate.

Here is an example image showing what I am trying to do:
sample_table

@glin
Copy link
Owner

glin commented May 16, 2021

Hi, I like the idea! If you want to submit a pull request, I'd be happy to review it.

@glin glin added the enhancement New feature or request label May 16, 2021
@ksnap28
Copy link
Author

ksnap28 commented May 17, 2021

Great! I submitted pull request #159

@glin glin closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants