Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsable rows #39

Closed
nergiszaim opened this issue Apr 10, 2020 · 2 comments
Closed

Collapsable rows #39

nergiszaim opened this issue Apr 10, 2020 · 2 comments

Comments

@nergiszaim
Copy link

When a sorting is done in expanded rows the rows goes back to collapse mode. Is there a way to avoid this?

@glin
Copy link
Owner

glin commented Apr 18, 2020

There isn't right now, but it may be possible in the future. I've looked into this before, and found that it was tricky to do because React Table only keeps track of expanded rows on the current page.

That means if you expand the 3rd row and sort the table, the 3rd row on the page would still be sorted, even though the row order is completely different. To keep the actual expanded row open would require some fighting around with library internals, so I've just put it off for now. But this is something I really want as well, so it may happen sooner than later.

@glin
Copy link
Owner

glin commented Jan 10, 2021

This is now fixed in the development version (d9ac371). Expanded rows should stay expanded on any sorting, filtering, and pagination changes.

@glin glin closed this as completed Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants