Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating footer when pagination is false #41

Closed
Kairi703 opened this issue Apr 14, 2020 · 3 comments
Closed

Floating footer when pagination is false #41

Kairi703 opened this issue Apr 14, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Kairi703
Copy link

Kairi703 commented Apr 14, 2020

Hi All,

Thanks for creating an amazing package, which helps with the huge reports I have to create right now.

When I use both footer and pagination = FALSE with a set height, the footer kinda floats on top of the table.

Example:

reactable(
iris[,-5],
defaultColDef = colDef(footer = function(values) sum(values)
),
wrap = TRUE,
pagination = FALSE,
highlight = TRUE,
height = 500,
columns = list(
Sepal.Length = colDef(name = "Sepal Length"),
Sepal.Width = colDef(filterable = TRUE),
Petal.Length = colDef(show = FALSE),
Petal.Width = colDef(defaultSortOrder = "desc")
)
)

@glin
Copy link
Owner

glin commented Apr 18, 2020

Thanks for reporting this. I've seen this before in either Safari or the RStudio Viewer, but I forgot to go back and investigate it. I think it's a browser bug with sticky elements. What browser are you using?

@Kairi703
Copy link
Author

Thanks for the reply. I checked, and the behavior only occurs in the Rstudio viewer, not in Edge or Chrome. I don't know about safari, as I don't use a Mac :) That makes it less of a worry for me, as my client does not use Rstudio viewer to check the html.

@glin
Copy link
Owner

glin commented May 28, 2020

I finally looked into this and found that it was caused by a flexbox bug in several browsers, including Safari and Chrome: https://github.com/philipwalton/flexbugs#flexbug-1.

The bug is supposed to be fixed in newer versions of Chrome and Safari, but I added a workaround for it anyway in 2bfeb40. So footers should no longer be floating for Chrome, Safari, and the RStudio Viewer.

@glin glin closed this as completed May 28, 2020
@glin glin added the bug Something isn't working label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants