Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates edit action #7

Open
Ashark opened this issue Jun 29, 2021 · 11 comments
Open

Templates edit action #7

Ashark opened this issue Jun 29, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Ashark
Copy link
Contributor

Ashark commented Jun 29, 2021

It seems that it is in development.
Some items are not displayed properly. For example, blank spaces instead of naming actions such as editing icon.
Also, when installing via Dolphin (get new thing button), there is no such action.
Looks like it is not yet published in https://www.pling.com/p/1454391/

@gmm96
Copy link
Owner

gmm96 commented Jun 29, 2021

As you finally said, it is not published yet in the Dolphin store because I need to make some more tests.
Which blank spaces do you mean? Can you please show me a screenshot pointing to that?

Kdialog (used tool to input from user) has limitations, specially formatting checklist options, I cannot use bold, italic, center or anything like that. My intention was to display the action and the current value associated below, something like this:

image

In this case, there's a blank line after Edit comment action, which means it has no value right now. Also after Save and exit action, but this action won't obviously have any value associated. Just in case these are the blank lines you're talking about.

I know it isn't the most usable interface you're going to see, but I think it's the most functional to read all the information and identifying every different thing. Anyway, I'm open minded, so I can heard your suggestions.

@Ashark
Copy link
Contributor Author

Ashark commented Jun 29, 2021

No, I was not talking about blank values, but about blank headers. Here is what it looks like:
blank headers

@Ashark
Copy link
Contributor Author

Ashark commented Jun 30, 2021

I am sorry, blank titles were because of incorrect translation file, which I saved when doing translation merge request. Ignore that statement.

it isn't the most usable interface, but I think it's the most functional to read all the information and identifying every different thing. Anyway, I'm open minded, so I can heard your suggestions.

Yes, I see, kdialog cannot handle more complex gui.

I have seen another variant of dialog tool called yad: Project homepage, screenshots with complex guis. Unfortunately, it is on gtk.

Another solution is to use qt. I do not know yet if it is possible to create qt gui right from bash, but it can be done via pyqt or c++. Do not know if it worth to rewrite this project on c++, but pyqt seems good to me! I had done pyqt guis several times.

@Ashark
Copy link
Contributor Author

Ashark commented Jun 30, 2021

Take a look at how ui could look:
Screenshot_20210630_114739

The file for this was made in qt designer, take it here.

@gmm96
Copy link
Owner

gmm96 commented Jul 1, 2021

I am sorry, blank titles were because of incorrect translation file, which I saved when doing translation merge request. Ignore that statement.

it isn't the most usable interface, but I think it's the most functional to read all the information and identifying every different thing. Anyway, I'm open minded, so I can heard your suggestions.

Yes, I see, kdialog cannot handle more complex gui.

I have seen another variant of dialog tool called yad: Project homepage, screenshots with complex guis. Unfortunately, it is on gtk.

Another solution is to use qt. I do not know yet if it is possible to create qt gui right from bash, but it can be done via pyqt or c++. Do not know if it worth to rewrite this project on c++, but pyqt seems good to me! I had done pyqt guis several times.

Great! I was also thinking about that cause, as it has also happened to me before.
I was looking for dialog tools before starting the project and finally decided for kdialog because is in KDE base and there is no need to download additional packages or dependencies.

Take a look at how ui could look:
Screenshot_20210630_114739

The file for this was made in qt designer, take it here.

Well, it looks pretty good, but, to be honest, I have never worked using qt, so I would need a further research.
I will release the current version with the editor and then we'll see.

blank headers

By the way, I can see in this screenshot Template Editor window icon (with value edit) is not showing for you.
Don't you have it? Can you run kdialog --geticon and search for edit?

@gmm96 gmm96 self-assigned this Jul 2, 2021
@gmm96 gmm96 added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jul 2, 2021
@Ashark
Copy link
Contributor Author

Ashark commented Jul 2, 2021

I have never worked using qt.

It is easier that you could think [I am talking about pyqt]. I also know nothing about it recently, but found a tutorial of how to work with it, and surprised how easy it was. It is in no way more complicated than bash!

Can you run kdialog --geticon and search for edit?

I do not have an icon with value edit:
Screenshot_20210702_055257

@gmm96
Copy link
Owner

gmm96 commented Jul 3, 2021

I have never worked using qt.

It is easier that you could think [I am talking about pyqt]. I also know nothing about it recently, but found a tutorial of how to work with it, and surprised how easy it was. It is in no way more complicated than bash!

Can you run kdialog --geticon and search for edit?

I do not have an icon with value edit:
Screenshot_20210702_055257

Well, let's see if I have free time in the next vacations to take a look of it.

WTF, you have all the edit-whatever icons, but no singe edit icon. This shouldn't be serious. Maybe editor could be a good option for it.
Do you have favorite and delete icons? Just to be sure.

@Ashark
Copy link
Contributor Author

Ashark commented Jul 3, 2021

Yes:
favorite
delete

Note, there is no xapp-favorite-symbolic icon, as I said in #5

@Ashark
Copy link
Contributor Author

Ashark commented Jul 3, 2021

Also, I have checked if such file should exist and belong to any package, got this:

$ pkgfile /usr/share/icons/breeze/actions/22/favorite.svg
extra/breeze-icons
$ pkgfile /usr/share/icons/breeze/actions/22/edit.svg
$

@Ashark
Copy link
Contributor Author

Ashark commented Jul 4, 2021

Maybe editor could be a good option for it.

Why not to just use the icon for the project? That is that icon png file with paper and letter T. Can you create an svg version and use it?

@gmm96
Copy link
Owner

gmm96 commented Jul 13, 2021

Yes:
favorite
delete

Note, there is no xapp-favorite-symbolic icon, as I said in #5

Also, I have checked if such file should exist and belong to any package, got this:

$ pkgfile /usr/share/icons/breeze/actions/22/favorite.svg
extra/breeze-icons
$ pkgfile /usr/share/icons/breeze/actions/22/edit.svg
$

Thanks for the help. I will try to avoid xapp-favorite-symbolic icon, then.

Why not to just use the icon for the project? That is that icon png file with paper and letter T. Can you create an svg version and use it?

I have tried to create different svg icons using Adobe Photoshop and the result was not fine. Depends on the KDE applied theme, the icon is displayed properly or not, specially using dark themes. I will use system default icons by now, until I would have a proper workaround to deal with it. You can check the icons I mentioned below.

icons.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants