Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on ill-formed input. #50

Closed
mocabe opened this issue Jun 14, 2018 · 4 comments
Closed

Crash on ill-formed input. #50

mocabe opened this issue Jun 14, 2018 · 4 comments

Comments

@mocabe
Copy link

mocabe commented Jun 14, 2018

Summary

Following code crashes mdmath extension.

>$$

$$

Actual behavior

After allocating huge amount of memory, extension crashes with error "FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory".

Steps to reproduce

Save following code as .md and open it with mdmath extension enabled.

>$$

$$

Related links

Environment

  Operating system: Win64
  VSCode version: Insider 1.25.0
  Markdown+Math version: v2.2.1
@goessner
Copy link
Owner

Yes ... I can reproduce this ... even with vscode version 1.24.

I need to have a deeper look into this and will come back to you here..

thanks

@goessner
Copy link
Owner

Implemented a bug fix with markdown-it-texmath.

But now fatal bug with ill behavior is gone with VSCode 1.26.0.

Thanks

This was referenced Aug 15, 2018
@91khr
Copy link

91khr commented Jan 20, 2019

It seems that this issue reappeared on VSCode 1.30.2 with Markdown+Math 2.3.7 ...

@goessner
Copy link
Owner

This is quite a pathological bug only occuring, if

  1. a display formula is opened inside of a blockquote section
  2. followed by an empty line outside of the blockquote section
  3. closing the display formula on a line followed outside of the blockquote section

i.e

>$$

$$

This bug in markdown-it-texmath is resolved with version 0.5.4. and also resolved therefore with mdmath version 2.3.8 available in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants