Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/refactor/inline: PkgName conflict #63298

Closed
adonovan opened this issue Sep 29, 2023 · 1 comment
Closed

x/tools/internal/refactor/inline: PkgName conflict #63298

adonovan opened this issue Sep 29, 2023 · 1 comment
Assignees
@adonovan
Labels
Refactoring Issues related to refactoring tools
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

Inlining this call:

L289:		hollowProxy, err := kubemark.NewHollowProxyOrDie(

of kubernetes/cmd/kubemark/hollow-node.go@4ce5a89 causes the import block to contain duplicate local names:

	iptables "k8s.io/kubernetes/pkg/proxy/iptables"
	iptables "k8s.io/kubernetes/pkg/proxy/util/iptables"
	utilflag "k8s.io/kubernetes/pkg/util/flag"
	iptables "k8s.io/kubernetes/pkg/util/iptables"

Clearly something is wrong in the fresh name algorithm.
@adonovan adonovan self-assigned this Sep 29, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 29, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 29, 2023
@adonovan adonovan added Refactoring Issues related to refactoring tools and removed Tools This label describes issues relating to any tools in the x/tools repository. labels Sep 29, 2023
@adonovan adonovan mentioned this issue Sep 29, 2023
Closed
9 tasks
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/531698 mentions this issue: internal/refactor/inline: don't add same import PkgName twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
Refactoring Issues related to refactoring tools
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@adonovan @gopherbot