Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: temporarily guard against range over func in staticcheck buildir analyzers #67947

Closed
findleyr opened this issue Jun 12, 2024 · 2 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

Reminder issue: the version of staticcheck linked by gopls does not yet support range over func. staticcheck@master has support, but this is not yet released in a stable version.

Before cutting [email protected], we should guard against running staticcheck analyzers that depend on staticcheck's buildir on code that uses range over func. We did this temporarily for buildssa by injecting a dependency analyzer that fails when it encounters range over func.

(for the record this issue is not meant in any way to rush staticcheck toward a release, but we can and should guard against running staticcheck on code that it doesn't yet support)

CC @adonovan @dominikh

@findleyr findleyr added this to the gopls/v0.16.0 milestone Jun 12, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 12, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@findleyr
Copy link
Contributor Author

Hah, this was already done in https://go.dev/cl/583778 (I thought that just covered buildssa).

Thanks, @gabyhelp!

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants