Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken docs check #4202

Closed
juliuskunze opened this issue Sep 3, 2020 · 4 comments
Closed

Broken docs check #4202

juliuskunze opened this issue Sep 3, 2020 · 4 comments
Assignees
Labels
bug Something isn't working build

Comments

@juliuskunze
Copy link
Contributor

juliuskunze commented Sep 3, 2020

The docs/readthedocs.org:jax check fails across PRs lately, i. e. here. The only error in the log is

ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

myst-parser 0.12.8 requires docutils>=0.15, but you'll have docutils 0.14 which is incompatible.
@shoyer
Copy link
Member

shoyer commented Sep 4, 2020

We might be able to fix this by pinning versions in our docs?
https://github.com/google/jax/blob/master/docs/requirements.txt

@froystig
Copy link
Member

froystig commented Sep 4, 2020

This looks like it may have been fixed (by RTD?) in the past 16+ hours, as the doc builds have started passing again. @shoyer, any thoughts on whether to add the requirement anyway? PR is ready, but I can discard it too.

@froystig froystig self-assigned this Sep 4, 2020
@froystig froystig added bug Something isn't working build labels Sep 4, 2020
@8bitmp3
Copy link
Contributor

8bitmp3 commented Sep 5, 2020

@froystig Thanks for bringing this up. This discussion on the readthedocs repo may be related - it seems to be pointing a similar issue at PiPy/pip: readthedocs/readthedocs.org#7362 (comment)

@froystig
Copy link
Member

I'm going to close this because it indeed seems to have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants