[Bug]: TestTurbiniaTaskBase allows to pass Evidence Class as parameter but instantiates RawDisk anyway

[HolzmanoLagrene]

What steps will reproduce the bug?

Using the regular developer setups as proposed in the Wiki when trying to create new Tests that do not use RawDisk as Evidence type

What is the expected behavior?

In my opinion when I look at these lines of code

turbinia/turbinia/workers/workers_test.py

Lines 47 to 49 in a56d21e

	def setUp(self, task_class=TurbiniaTask, evidence_class=evidence.RawDisk):
	self.task_class = task_class
	self.evidence_class = evidence_class

I expect to be able to pass a Evidence type and use that in the unittest.

What do you see instead?

Looking at a couple of lines later we see this:

turbinia/turbinia/workers/workers_test.py

Line 70 in a56d21e

self.evidence = evidence.RawDisk(source_path=test_disk_path)

This will, in any case, set the self.evidence object to Evidence of type RawDisk

Additional information

Not sure if this is a bug or a misunderstanding on my side, but intuitively I would expect the Evidence type class to be instantiated and assigned to self.evidence later. Something like this:

self.task_class = task_class
self.evidence_class = evidence_class
...
self.evidence = self.evidence_class()

The task_class parameter does that in the line:

turbinia/turbinia/workers/workers_test.py

Line 59 in a56d21e

self.task = self.task_class(base_output_dir=self.base_output_dir)