Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Upgrade Turbinia API client to Pydantic v2 #1484

Open
jleaniz opened this issue May 22, 2024 · 1 comment
Open

[FR]: Upgrade Turbinia API client to Pydantic v2 #1484

jleaniz opened this issue May 22, 2024 · 1 comment
Assignees
Labels
enhancement Needs triage New issues that need triage

Comments

@jleaniz
Copy link
Collaborator

jleaniz commented May 22, 2024

What is the feature you are proposing?

Generate an API client that uses Pydantic version 2.

What would this feature improve or what problem would it solve?

The OpenAPI code generator does not support chunked transfers with the Pydantic v1 models. Migrating to v2 would allow the API to stream files which would be useful for the /result endpoints

What alternatives have you considered?

No response

@jleaniz jleaniz added enhancement Needs triage New issues that need triage labels May 22, 2024
@jleaniz jleaniz self-assigned this May 22, 2024
@jleaniz
Copy link
Collaborator Author

jleaniz commented Jun 18, 2024

  • Provide additional output before attempting actions like downloading files.
  • For file streaming, provide download size stats / progress

@jleaniz jleaniz mentioned this issue Jun 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs triage New issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant