Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Revoked tasks are not handled properly #1539

Closed
jleaniz opened this issue Aug 30, 2024 · 0 comments · Fixed by #1540
Closed

[Bug]: Revoked tasks are not handled properly #1539

jleaniz opened this issue Aug 30, 2024 · 0 comments · Fixed by #1540
Assignees
Labels
bug Needs triage New issues that need triage

Comments

@jleaniz
Copy link
Collaborator

jleaniz commented Aug 30, 2024

What steps will reproduce the bug?

A task could take longer to start running on a worker than the pre-defined celery hard-timeout. For example, if the queue is backed up due to not having enough workers to process each task. Celery will revoke tasks that did not execute before the expiration time that is set when creating the task.

What is the expected behavior?

Turbinia should handle cases in which the task is revoked by Celery and not "closed" by Turbinia itself. In my opinion, such tasks should just fail after a reasonable amount of time (e.g. 24 hours).

What do you see instead?

Revoked tasks are not handled and the Turbinia server thinks they are still pending in the message queue.

Additional information

No response

@jleaniz jleaniz added bug Needs triage New issues that need triage labels Aug 30, 2024
@jleaniz jleaniz self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs triage New issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant