Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] go test @ 1.5.2 fails #924

Closed
1 task done
tebuka opened this issue Jun 8, 2024 · 1 comment · Fixed by #926
Closed
1 task done

[BUG] go test @ 1.5.2 fails #924

tebuka opened this issue Jun 8, 2024 · 1 comment · Fixed by #926
Labels
bug

Comments

@tebuka
Copy link

tebuka commented Jun 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The go test command reports failure.

Expected Behavior

The tests pass.

Steps To Reproduce

$ mkdir fail
$ cd fail
$ go mod init fail.com
$ go get github.com/gorilla/[email protected]
$  go test github.com/gorilla/websocket
# go test prints fail message

Anything else?

The maintainers should run the tests before cutting a new release.
@tebuka tebuka added the bug label Jun 8, 2024
@FZambia
Copy link
Contributor

FZambia commented Jun 9, 2024 •
edited
Loading

There was a fix for tests submitted - #920 – but it was missed/ignored.

@apoorvajagtap apoorvajagtap mentioned this issue Jun 12, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes broken random value generation apoorvajagtap/gorilla-websocket
1 participant
@FZambia