Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow favoring your own posts from the post page #647

Open
cirosantilli opened this issue Apr 22, 2021 · 1 comment
Open

Allow favoring your own posts from the post page #647

cirosantilli opened this issue Apr 22, 2021 · 1 comment
Labels
Status: RFC awaiting for comments to be approved v2 changelog

Comments

@cirosantilli
Copy link
Contributor

cirosantilli commented Apr 22, 2021

Just a small thing that confused me a bit: current behavior on https://github.com/gothinkster/vue-realworld-example-app and https://github.com/gothinkster/react-redux-realworld-example-app :

It is a bit weird to only be able to do it from one place but not the other, I'd just add the button favorite button in addition to the delete button.

Also:

  • backends likely don't forbid favoriting self, so neither should frontend
  • you are unable to see how many favorites your own post has while logged in, since that is shown on the button itself
@mvila
Copy link
Member

mvila commented Apr 22, 2021

It is indeed not very coherent. Let's make sure it is fixed in v2.

@mvila mvila added the v2 label Apr 22, 2021
@geromegrignon geromegrignon added Status: RFC awaiting for comments to be approved and removed v2 labels Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: RFC awaiting for comments to be approved v2 changelog
Projects
None yet
Development

No branches or pull requests

3 participants