Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "500 tagList.map is not a function" if empty string sent instead of tagList #803

Closed
concise-studio opened this issue Nov 9, 2021 · 2 comments
Closed

[Bug]: "500 tagList.map is not a function" if empty string sent instead of tagList #803

concise-studio opened this issue Nov 9, 2021 · 2 comments
Assignees
@geromegrignon
Labels
bug

Comments

@concise-studio
Copy link

concise-studio commented Nov 9, 2021 •
edited

Relevant scope

Deployed demo

Description

If user did no fill the field 'tags', it is possible that frontend will send empty string in the 'tagList' parameter. In my opinion, if empty string is not allowed, API should return validation error (422), not internal error (500).
@geromegrignon
Copy link
Contributor

Hey @concise-studio, by creating the current API, I didn't include this 'feature' (tracked by #410).
I'll deploy a bug fix to match the previous API not to break existing implementations.

@geromegrignon geromegrignon mentioned this issue Nov 11, 2021
Merged
@geromegrignon
Copy link
Contributor

It should be fixed by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geromegrignon geromegrignon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geromegrignon @concise-studio