Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Links in package guides don't navigate correctly #2815

Closed
Tracked by #2682
damienwebdev opened this issue May 28, 2024 · 1 comment · Fixed by #2877 or #2893
Closed
Tracked by #2682

[BUG] Links in package guides don't navigate correctly #2815

damienwebdev opened this issue May 28, 2024 · 1 comment · Fixed by #2877 or #2893
Assignees
@griest024
Labels
bug A confirmed bug report docs This issue is related to documentation p1 critical priority
Milestone
Daffodil v1.0

Comments

@damienwebdev
Copy link
Member

damienwebdev commented May 28, 2024 •
edited
Loading

https://next.daff.io/docs/packages/cart/installation
@damienwebdev damienwebdev mentioned this issue May 28, 2024
Open
26 tasks
@damienwebdev damienwebdev changed the title Links in package guides dont navigate correctly [BUG] Links in package guides dont navigate correctly May 28, 2024
@xelaint xelaint changed the title [BUG] Links in package guides dont navigate correctly [BUG] Links in package guides don't navigate correctly May 28, 2024
@xelaint xelaint added bug A confirmed bug report docs This issue is related to documentation labels May 28, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone May 28, 2024
@xelaint xelaint added the p1 critical priority label May 28, 2024
@xelaint xelaint mentioned this issue Jun 11, 2024
Open
26 tasks
@griest024 griest024 mentioned this issue Jun 13, 2024
Closed
@griest024 griest024 self-assigned this Jun 14, 2024
@griest024
Copy link
Member

this is tricky. in order to correctly generate links, dgeni must first resolve the relative path to find the referenced doc and then infer the type of doc to determine the routing path. e.g. if a generic guide (/docs/guides/search.md) references a package guide (/libs/search/guides/search.md) dgeni must know that the link should be /docs/packages/search/search.md.

@griest024 griest024 mentioned this issue Jun 15, 2024
Merged
3 tasks
@xelaint xelaint mentioned this issue Jul 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griest024 griest024

Labels
bug A confirmed bug report docs This issue is related to documentation p1 critical priority
Projects
None yet
Milestone
Daffodil v1.0
3 participants
@griest024 @damienwebdev @xelaint