Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coincident edge label display #86

Open
vincerubinetti opened this issue Jun 18, 2019 · 1 comment
Open

Fix coincident edge label display #86

vincerubinetti opened this issue Jun 18, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Jun 18, 2019

Currently the edge label is positioned outside/along the line. Let's move it to in the center of the line with a white outline.

This will eliminate the code that determines whether the text is displayed on the "outside" of the curve, which was error prone and complicated.

Several ways to accomplish this. Will test to see which is best.

@vincerubinetti vincerubinetti added the todo An action item label Jun 18, 2019
@vincerubinetti vincerubinetti added wontfix This will not be worked on and removed todo An action item labels Jul 29, 2019
@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Jul 29, 2019

I think the performance is too important in this case to actually implement what I said in the original post. As such, changing this issue to "Fix coincident edge label display". I remember seeing a very specific case where the positioning of them is screwed up (but the consequence is just that the text is upside-down, I believe, so considering this an enhancement). Will test various inputs to try to find it, and make sure it can handle anything.

@vincerubinetti vincerubinetti added enhancement New feature or request and removed wontfix This will not be worked on labels Jul 29, 2019
@vincerubinetti vincerubinetti changed the title Change graph edge label display Fix coincident edge label display Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant