Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should exclude PSK_DHE mode when key_share is null #531

Open
sshock opened this issue May 31, 2024 · 0 comments
Open

Should exclude PSK_DHE mode when key_share is null #531

sshock opened this issue May 31, 2024 · 0 comments

Comments

@sshock
Copy link
Contributor

sshock commented May 31, 2024

The ptls_context_t key_exchanges can be set to NULL to force PSK-only mode.

In this scenario, the client key_share_ctx is NULL, so encode_client_hello does not include any key_share entries.

So far so good. But encode_client_hello still includes PSK_DHE in the PSK_KEY_EXCHANGE_MODES, even though that mode won't be able to work.

In practice this hasn't caused any issues for me, but it would probably be good to exclude that mode in this scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sshock