New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pymatgen preset in ElementProperty #129

Open

computron opened this issue Feb 9, 2018 · 1 comment

Contributor

computron commented Feb 9, 2018

The features chosen for the "pymatgen" preset are somewhat random (I chose them on a whim, based on no data, while coding in a rush)

Someone can try to do a better job with this...

Contributor Author

computron commented Jun 1, 2018

Another thing one could do is:

"pymatgen" preset just contains a large list of pymatgen element properties
add a new "matminer" preset that tries to find all the independent columns between DEML, Magpie, pymatgen (i.e., columns that are not just linearly dependent on one another) and combine all those into one preset.

ardunn mentioned this issue

Add more featurizers to AllFeaturizers hackingmaterials/automatminer#60

Closed

ardunn added the ugrads label

ardunn removed the ugrads label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment