Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks are rendered but are not clickable #160

Open
steghoja opened this issue May 23, 2022 · 5 comments
Open

Hyperlinks are rendered but are not clickable #160

steghoja opened this issue May 23, 2022 · 5 comments

Comments

@steghoja
Copy link

For a simple dot file such as the one below, the links are rendered correctly, but they are not clickable. Im am using the PlantUML plugin in version 1.1.26. This certainly worked in a previous versions, so maybe this is a regression.

@startuml
left to right direction
object "Test1 [[http://eclipse.org (Go to)]]" as o0 #pink
object "Test2 [[http://eclipse.org (Go to)]]" as o1
o0--o1: Connection
@enduml
@hallvard
Copy link
Owner

The links are rendered by the underlying library, but the plugin handles the clickability, based on link coordinates that are reported by the library. There may be some mistake in these coordinates and/or how they are used, can you see if you some other rectangles in the viewport are clickable and if there seems to be some systematic offset and/or scaling error?

@steghoja
Copy link
Author

steghoja commented Jun 1, 2022

Yes, there seems to be an offset! It is towards the left of the link, in the example it is right on the lefthand boundary of the rectangle for the object. But the clickable area also seems to have incorrect width and height -- it only seems to be some pixels wide and high.

@steghoja
Copy link
Author

steghoja commented Jun 1, 2022

I cannot, however, find the clickable area for the second link for the "Test2" object in the example.

@hallvard
Copy link
Owner

hallvard commented Sep 8, 2022

I can reproduce it and will have a look. Thanks for reporting!

@hallvard
Copy link
Owner

hallvard commented Sep 8, 2022

In an earlier release I added workaround code to handle a bug in the underlying plantuml library concerning links, and now the workaround doesn't seem to work anymore. At least, after commenting it out, the problem seems to be gone. Hopefully, the underlying library has fixed its bug, so the workaround isn't needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants