Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize parse transaction on prechecks #349

Closed
natanasow opened this issue Jul 19, 2022 · 0 comments · Fixed by #350
Closed

Optimize parse transaction on prechecks #349

natanasow opened this issue Jul 19, 2022 · 0 comments · Fixed by #350
Assignees
@natanasow
Labels
enhancement New feature or request limechain P2
Projects
Development
Milestone
0.5.0

Comments

@natanasow
Copy link
Collaborator

Problem

On each precheck, we parse the transaction instead of parsing it once and pass it to all checks parsed.

Solution

  • Parse the tx in the sendRawTransaction method
  • Pass the parsed tx to the prechecks

Alternatives

No response
@natanasow natanasow added the enhancement New feature or request label Jul 19, 2022
@natanasow natanasow self-assigned this Jul 19, 2022
@natanasow natanasow mentioned this issue Jul 19, 2022
Merged
2 tasks
@natanasow natanasow added this to For Review in Development Jul 19, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 19, 2022
Development automation moved this from For Review to Done Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natanasow natanasow

Labels
enhancement New feature or request limechain P2
Projects
Development
Done
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Optimize parse transaction on prechecks hashgraph/hedera-json-rpc-relay
2 participants
@natanasow @Nana-EC