Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptancetest check seems inconsistent #381

Closed
lukelee-sl opened this issue Jul 25, 2022 · 3 comments · Fixed by #430
Closed

acceptancetest check seems inconsistent #381

lukelee-sl opened this issue Jul 25, 2022 · 3 comments · Fixed by #430
Assignees
Labels
enhancement New feature or request limechain P2
Projects
Milestone

Comments

@lukelee-sl
Copy link
Member

Problem

The pr for issue #374 required 7 attempts to run acceptancetest check before succeeding. When looking at the logs, many of the attempts seemed to fail on different tests.

When running acceptancetest against a local node, what docker desktop resources are necessary to run complete successfully?

Solution

Examine the logs to see if there is a cause for the failures can be determined.
Noticed that the acceptance tests are run without the @global flag. Would tests succeed more consistently if this flag was turned on when running this step?

Alternatives

No response

@lukelee-sl lukelee-sl added enhancement New feature or request limechain labels Jul 25, 2022
@Nana-EC Nana-EC added the P2 label Jul 25, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 25, 2022
@Nana-EC Nana-EC added this to Sprint Commitment in Development Jul 25, 2022
@Kalina-Todorova Kalina-Todorova moved this from Sprint Commitment to In progress in Development Aug 1, 2022
@Nana-EC Nana-EC modified the milestones: 0.5.0, 0.6.0 Aug 1, 2022
@ar-conmit
Copy link
Collaborator

ar-conmit commented Aug 3, 2022

One of the issues:

Error: invalid hexlify value (argument="value", value="bf6bc9564689d36d330b2e14d6983538afb6bd9aabd604903df94196d15fc5", code=INVALID_ARGUMENT, version=bytes/5.6.1)

Occurs when creating an alias account, the raw private key generated from the sdk sometimes is less than 32 bytes, so ethers cannot parse it and throws an error.
Addressed and described more in details here

@georgi-l95
Copy link
Collaborator

georgi-l95 commented Aug 4, 2022

Issue when calling eth_feeHistory with newest > latest block. We are caching the latest block and setting the newest to be 10 ahead and by the time we request the latest, it’s already one ahead. So we are expecting to be 10 blocks beyond, but sometimes it’s actually 11 blocks.

-Request beyond head block: requested 85, head 76
+Request beyond head block: requested 85, head 75

@ar-conmit
Copy link
Collaborator

Found another issue

1) RPC Server Acceptance Tests
       Acceptance tests
         RPC Server Acceptance Tests
           RPC Server Acceptance Tests
             "before all" hook in "RPC Server Acceptance Tests":
     Request failed with status code 404

Caused by one of the record .rcd files that contains token create transaction. The mirror importer cannot populate the database, the insert token query is incorrect and the postgres throws ERROR:  invalid input value for enum token_type: "CONTRACT" at character 1881

@georgi-l95 georgi-l95 self-assigned this Aug 5, 2022
@georgi-l95 georgi-l95 linked a pull request Aug 8, 2022 that will close this issue
2 tasks
@Kalina-Todorova Kalina-Todorova moved this from In progress to For Review in Development Aug 8, 2022
Development automation moved this from For Review to Done Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P2
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants