Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls with bad data to JSON RPC Relay should return an error response #385

Closed
mok0230 opened this issue Jul 26, 2022 · 0 comments · Fixed by #390
Closed

Calls with bad data to JSON RPC Relay should return an error response #385

mok0230 opened this issue Jul 26, 2022 · 0 comments · Fixed by #390
Labels
bug Something isn't working limechain P1
Projects
Milestone

Comments

@mok0230
Copy link

mok0230 commented Jul 26, 2022

Description

I made a eth_sendRawTransaction call with bad data but did not receive an error response (receives 200 success). This may be expected behavior (see repro below).

Steps to reproduce

  1. Make a call to eth_sendRawTransaction with data similar to below - updated according to the nonce of the sending account and signed:
{
  data: '0x06e8fac2000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000003666f6f0000000000000000000000000000000000000000000000000000000000',
  to: '0x000000000000000000000000000000000214db10',
  from: '0x205399A519D341051E86e790AaA0F713340745CA',
  type: 2,
  maxFeePerGas: BigNumber { _hex: '0x026705ab4f00', _isBigNumber: true },
  maxPriorityFeePerGas: BigNumber { _hex: '0x59682f00', _isBigNumber: true },
  nonce: 87,
  gasLimit: BigNumber { value: "30678687678687676876786786876876876000" },
  chainId: 296
}
  1. Response is not an error, instead it is:
{
  reason: 'overflow',
  code: 'NUMERIC_FAULT',
  fault: 'overflow',
  operation: 'toNumber',
  value: '30678687678687676876786786876876876000'
}

Additional context

No response

Hedera network

testnet

Version

v0.3.0

Operating system

macOS

@mok0230 mok0230 added the bug Something isn't working label Jul 26, 2022
@mok0230 mok0230 changed the title Failed calls to JSON RPC Relay should return an error response Calls with bad data to JSON RPC Relay should return an error response Jul 26, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 27, 2022
@Nana-EC Nana-EC added this to Sprint Commitment in Development Jul 27, 2022
@Kalina-Todorova Kalina-Todorova moved this from Sprint Commitment to In progress in Development Jul 28, 2022
@Kalina-Todorova Kalina-Todorova moved this from In progress to For Review in Development Jul 29, 2022
Development automation moved this from For Review to Done Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain P1
Projects
Development

Successfully merging a pull request may close this issue.

2 participants