Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hardhat-verify plugin works properly in our Sourcify instance #109

Closed
acuarica opened this issue Dec 18, 2023 · 4 comments
Closed
Assignees

Comments

@acuarica
Copy link
Contributor

There is a Hardhat plugin that allows developers to verify contracts using Etherscan and Sourcify.

Developers who use Hardhat in their workflow may use this plugin for verification. So it's important for our users to support this plugin as well. Moreover, we can leverage this plugin as an e2e test when we expose API access for our Sourcify instance.

It looks like this plugin allows for API endpoint customization. See https://github.com/NomicFoundation/hardhat/blob/377796b177deb1bb3585d4460c0dc9bd0f3a98b1/packages/hardhat-verify/src/internal/config.ts#L34-L46. We may be able to use this to point to our instance.

Ultimately, we need to ensure a developer who installs hardhat-verify and configure the verification with our instance, can run npx hardhat verify successfully.

@svienot
Copy link
Contributor

svienot commented Dec 18, 2023

I made a very quick tour of the toolsets listed by sourcify.dev in this issue: #597

@acuarica
Copy link
Contributor Author

They added this new configuration recently NomicFoundation/hardhat@8ce5602 😄 . We should be able to integrate with this plugin.

@acuarica acuarica self-assigned this Jan 12, 2024
@acuarica
Copy link
Contributor Author

Confirmed that our sourcify instance works with hardhat-verify plugin. Docs have been added in

@acuarica
Copy link
Contributor Author

Although it works, there might be an unrelated Etherscan error showing in the hardhat output. To suppress it, it is needed to manually disable Etherscan verification since hardhat doesn't do it automatically[1]

etherscan: {
  enabled: false,
}

[1] NomicFoundation/hardhat#4776 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants