Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric support for services #40

Closed
Nana-EC opened this issue Oct 11, 2023 · 1 comment · Fixed by #131
Closed

Add metric support for services #40

Nana-EC opened this issue Oct 11, 2023 · 1 comment · Fixed by #131
Assignees
Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented Oct 11, 2023

Problem

The open-source sourcify repo has in built grafana metrics support which we were not able to leverage in initial usgage

Solution

Explore and add capabilities to enable in built metrics to flow and be scraped by grafana services

Alternatives

No response

@Nana-EC Nana-EC added Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone. labels Oct 11, 2023
@svienot
Copy link
Contributor

svienot commented Dec 14, 2023

The sourcify environments folder contains set-up to launch various containers related to the monitoring of the systems:

  • cadvisor: exports container-based metrics
  • node exporter: exports host and OS-based metrics
  • promtail: exports local logs
  • loki: log aggregator
  • grafana: visualisation
  • nginx prometheus exporter: exports nginx metrics
  • prometheus: metrics and alerting

I understand this set-up is neither complete, nor up-to-date and it looks like it no longer exists today in the upstream sourcify repository.

There are no application-specific metrics in the code today.

I got a reply on this subject a while ago from marco castignoli who is one of the sourcify.dev developers:

"We are currently monitoring every metric using a separate grafana service that monitors our kubernetes pods, everything about grafana / node_exporter / cadvisor you read in the repo is old.
We also have an event manager class that logs different kind of events that can be used to track different sourcify specific metrics. These are the events that we monitor:

		"Verification.MatchStored"
		"Server.SourcifyChains.Warn"
		"SourceFetcher.UsingFallback"
		"SourceFetcher.NewSubscription"
		"SourceFetcher.Cleanup"
		"SourceFetcher.FetchFailed"
		"SourceFetcher.FetchingSuccessful"

Not many actually, we are thinking about removing this EventManager....
"

From this it looks like one of the events logged: "Verification.MatchStored"

 could be helpful to track the verified contract flow.

@svienot svienot assigned acuarica and unassigned svienot Dec 14, 2023
@acuarica acuarica linked a pull request Feb 7, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants