Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support semantic syntax highlighting #264

Closed
radeksimko opened this issue Aug 26, 2020 · 1 comment · Fixed by #331
Closed

Support semantic syntax highlighting #264

radeksimko opened this issue Aug 26, 2020 · 1 comment · Fixed by #331
Assignees
Labels
enhancement New feature or request textDocument/semanticTokens Semantic syntax highlighting

Comments

@radeksimko
Copy link
Member

Current Version

0.6.1

Background

Syntax highlighting is currently done on the client, which means that each client implements their own logic and deals with their own bugs. This is because LSP historically did not provide a way of highlighting a document via protocol.

Proposal

Upcoming LSP 3.16 has support for textDocument/semanticTokens which the server could implement and provide a single source of truth for how to highlight a document.

NodeJS client implementation is available in microsoft/vscode-languageserver-node#367

Related LSP methods

https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/#textDocument_semanticTokens

@radeksimko radeksimko added enhancement New feature or request lsp textDocument/semanticTokens Semantic syntax highlighting labels Aug 26, 2020
@paultyng paultyng self-assigned this Sep 1, 2020
@paultyng paultyng removed their assignment Nov 17, 2020
@radeksimko radeksimko self-assigned this Nov 17, 2020
@ghost
Copy link

ghost commented Feb 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request textDocument/semanticTokens Semantic syntax highlighting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants