Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration for Push Notification parameters #306

Open
markusmauch opened this issue Jun 13, 2024 · 7 comments
Open

Allow configuration for Push Notification parameters #306

markusmauch opened this issue Jun 13, 2024 · 7 comments

Comments

@markusmauch
Copy link

markusmauch commented Jun 13, 2024

Problem/Motivation

Vaultwarden allows to set up Push Notification to send authentication requests from the web extension to the mobile app in order to use biometric authentication. The respective settings can be provided via environment variables:

PUSH_ENABLED=true
PUSH_INSTALLATION_ID=....
PUSH_INSTALLATION_KEY=....
PUSH_RELAY_BASE_URI=https://push.bitwarden.com

I tried to edit the config.json in the data directory of the addon accordingly and was able to set up Push Notifications. So it's just a matter of adding the settings in the addon configuration and start the vaultwarden container with theses additional env variables.

See also here:
https://2nistech.world/vaultwarden-activate-push-notification-for-mobile-devices/
https://github.com/dani-garcia/vaultwarden/wiki/Enabling-Mobile-Client-push-notification

Expected behavior

It should be possible to specify push notification settings in configuration of the addon

Actual behavior

It is not possible to specify push notification settings in configuration of the addon

Steps to reproduce

Proposed changes

@pmetzke
Copy link

pmetzke commented Jul 6, 2024

@markusmauch - thanks for testing to see if this would work!

It would be awesome to get these settings in the addon configuration.

@Salvora
Copy link

Salvora commented Jul 13, 2024

Also, waiting for this.
Additionally, if we can define environment variables. It is also possible to use MySQL or MariaDB as backend.
https://github.com/dani-garcia/vaultwarden/wiki/Using-the-MariaDB-%28MySQL%29-Backend

@dewet22
Copy link

dewet22 commented Jul 26, 2024

Another 2p: I'd like to set the DOMAIN variable to enable U2F / FIDO2 WebAuthn.

@cuza
Copy link

cuza commented Jul 30, 2024

@dewet22

Another 2p: I'd like to set the DOMAIN variable to enable U2F / FIDO2 WebAuthn.

You can set that in the vaultwarden admin page (/admin) and use U2F / FIDO2 WebAuthn without problems

image

@dewet22
Copy link

dewet22 commented Jul 30, 2024

You can set that in the vaultwarden admin page (/admin) and use U2F / FIDO2 WebAuthn without problems

So odd! I don't remember seeing that at all. I ended up hosting vaultwarden on my homelab instead where I have better storage protection / backups anyway, but thanks for the tip!

@neckaros
Copy link

neckaros commented Aug 7, 2024

Problem/Motivation

Vaultwarden allows to set up Push Notification to send authentication requests from the web extension to the mobile app in order to use biometric authentication. The respective settings can be provided via environment variables:

PUSH_ENABLED=true PUSH_INSTALLATION_ID=.... PUSH_INSTALLATION_KEY=.... PUSH_RELAY_BASE_URI=https://push.bitwarden.com

I tried to edit the config.json in the data directory of the addon accordingly and was able to set up Push Notifications. So it's just a matter of adding the settings in the addon configuration and start the vaultwarden container with theses additional env variables.

See also here: https://2nistech.world/vaultwarden-activate-push-notification-for-mobile-devices/ https://github.com/dani-garcia/vaultwarden/wiki/Enabling-Mobile-Client-push-notification

Expected behavior

It should be possible to specify push notification settings in configuration of the addon

Actual behavior

It is not possible to specify push notification settings in configuration of the addon

Steps to reproduce

Proposed changes

You mean editing the config**.yaml** on this repo or you did a modification on your installation?
First time looking at a HA addon but i think config.yaml is indeed where the magix should happen. Can you send a merge request if you successfully did it?

@StrausFuenf
Copy link

Problem/Motivation

Vaultwarden allows to set up Push Notification to send authentication requests from the web extension to the mobile app in order to use biometric authentication. The respective settings can be provided via environment variables:
PUSH_ENABLED=true PUSH_INSTALLATION_ID=.... PUSH_INSTALLATION_KEY=.... PUSH_RELAY_BASE_URI=https://push.bitwarden.com
I tried to edit the config.json in the data directory of the addon accordingly and was able to set up Push Notifications. So it's just a matter of adding the settings in the addon configuration and start the vaultwarden container with theses additional env variables.
See also here: https://2nistech.world/vaultwarden-activate-push-notification-for-mobile-devices/ https://github.com/dani-garcia/vaultwarden/wiki/Enabling-Mobile-Client-push-notification

Expected behavior

It should be possible to specify push notification settings in configuration of the addon

Actual behavior

It is not possible to specify push notification settings in configuration of the addon

Steps to reproduce

Proposed changes

You mean editing the config**.yaml** on this repo or you did a modification on your installation? First time looking at a HA addon but i think config.yaml is indeed where the magix should happen. Can you send a merge request if you successfully did it?

Its possible I forked this repo and made it possible. frenck already had another Issue with that and moved it to the Discussions tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants